Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fixes post Aave3.2 #880

Merged
merged 55 commits into from
Oct 20, 2024
Merged

Test fixes post Aave3.2 #880

merged 55 commits into from
Oct 20, 2024

Conversation

QGarchery
Copy link
Contributor

@QGarchery QGarchery commented Oct 10, 2024 •
edited by MathisGD
Loading

This PR:

  • updates tests to the new version of Aave, v3.2
  • makes so the latest block is used for the tests
  • fixes the issue on the evm_version, where PUSH0 is not supported when evm_version = paris
  • fixes the issue on the AAVE token where it's not possible to deal tokens
  • fixes the issue on the new gas constraint from forge
  • fixes the tests to use the new pool configurator functions
  • updates the rewards tests
  • fixes various test bounds being too restrictive

See changes from aave-v3.2

@QGarchery QGarchery self-assigned this Oct 10, 2024
QGarchery
QGarchery commented Oct 10, 2024
View reviewed changes
test/helpers/ForkTest.sol Outdated Show resolved Hide resolved
@MathisGD MathisGD mentioned this pull request Oct 13, 2024
Closed
@MathisGD MathisGD mentioned this pull request Oct 14, 2024
Closed
@MathisGD MathisGD changed the title Test: fix on new blocks Fixes post Aave3.2 Oct 14, 2024
@MathisGD MathisGD changed the title Fixes post Aave3.2 Test fixes post Aave3.2 Oct 16, 2024
MathisGD
MathisGD previously approved these changes Oct 16, 2024
View reviewed changes
@MathisGD MathisGD marked this pull request as ready for review October 16, 2024 13:36
QGarchery
QGarchery commented Oct 16, 2024
View reviewed changes
Copy link
Contributor Author

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rubilmax
Rubilmax reviewed Oct 16, 2024
View reviewed changes
foundry.toml Show resolved Hide resolved
test/helpers/ForkTest.sol Show resolved Hide resolved
test/integration/TestIntegrationEModeNative.sol Show resolved Hide resolved
test/integration/TestIntegrationWithdraw.sol Outdated Show resolved Hide resolved
@QGarchery QGarchery mentioned this pull request Oct 17, 2024
Open
MathisGD
MathisGD previously approved these changes Oct 17, 2024
View reviewed changes
MathisGD
MathisGD previously approved these changes Oct 17, 2024
View reviewed changes
@MathisGD MathisGD merged commit 2c92c69 into main Oct 20, 2024
9 checks passed
@MathisGD MathisGD deleted the test/aave-v3.2 branch October 20, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rubilmax Rubilmax Rubilmax left review comments

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@MathisGD MathisGD MathisGD approved these changes

Assignees

@QGarchery QGarchery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QGarchery @MathisGD @Rubilmax @MerlinEgalite