Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow image storage location to be configured #976

Merged
merged 10 commits into from
Sep 18, 2024

Conversation

firstof9
Copy link
Collaborator

Proposed change

Adds option to change image storage location.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

@firstof9 firstof9 added the feature New feature or request label Sep 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.98%. Comparing base (8608d22) to head (be4602a).
Report is 33 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #976      +/-   ##
==========================================
- Coverage   95.07%   93.98%   -1.09%     
==========================================
  Files           8        8              
  Lines        1482     1596     +114     
==========================================
+ Hits         1409     1500      +91     
- Misses         73       96      +23     
Files with missing lines Coverage Δ
...stom_components/mail_and_packages/binary_sensor.py 97.36% <100.00%> (+0.18%) ⬆️
custom_components/mail_and_packages/config_flow.py 95.65% <100.00%> (-4.35%) ⬇️
custom_components/mail_and_packages/const.py 100.00% <100.00%> (ø)
custom_components/mail_and_packages/helpers.py 92.78% <100.00%> (-1.94%) ⬇️

... and 2 files with indirect coverage changes

@firstof9 firstof9 marked this pull request as ready for review September 18, 2024 17:42
@firstof9 firstof9 merged commit 2f57315 into moralmunky:dev Sep 18, 2024
5 checks passed
@firstof9 firstof9 deleted the fix-975 branch September 18, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants