feat(shipper): update intelcom, ups and amazon with canadian french strings #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically redone moralmunky#842 for the correct branch - Add french strings to amazon + canadian french AMAZON_LANG - Add french string to ups - IntelCom section with french contents
Bluscream
changed the title
firstof9
changed the title
firstof9
added
the
enhancement
To hopefully fix the issue tox's linter has with this PR
Bluscream
commented
Jul 18, 2024
| "update-bestelling@", | ||
| "versandbestaetigung@" | ||
| ] | ||
| AMAZON_EMAIL = ["order-update@", "update-bestelling@", "versandbestaetigung@"] |
There was a problem hiding this comment.
what a dumb change, but apparently the linter is happy now, so be it ig
linter helped me find that lol
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #954 +/- ##
==========================================
- Coverage 95.07% 93.43% -1.64%
==========================================
Files 8 8
Lines 1482 1554 +72
==========================================
+ Hits 1409 1452 +43
- Misses 73 102 +29
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically redone #842 for the correct branch
Breaking change
Proposed change
Type of change
Additional information