Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: redact amazon forward emails from diagnostics #948

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

firstof9
Copy link
Collaborator

Proposed change

Redact amazon forward emails from diagnostics

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

  • This PR is related to issue: n/a

@firstof9 firstof9 added the code-quality Improves code quality or adds/updates tests label Jul 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.30%. Comparing base (8608d22) to head (6913201).
Report is 23 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #948      +/-   ##
==========================================
- Coverage   95.07%   93.30%   -1.77%     
==========================================
  Files           8        8              
  Lines        1482     1554      +72     
==========================================
+ Hits         1409     1450      +41     
- Misses         73      104      +31     
Files Coverage Δ
custom_components/mail_and_packages/diagnostics.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@firstof9 firstof9 marked this pull request as ready for review July 12, 2024 18:07
@firstof9 firstof9 merged commit 1c983a5 into moralmunky:dev Jul 12, 2024
5 checks passed
@firstof9 firstof9 deleted the redact-fwds branch July 13, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Improves code quality or adds/updates tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants