Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the amazon config flow, use less searching #939

Merged
merged 17 commits into from
Jul 6, 2024

Conversation

firstof9
Copy link
Collaborator

@firstof9 firstof9 commented Jul 6, 2024

Breaking change

Change the configuration for Amazon sensors, use less searches, has user setup amazon domain.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

  • This PR is related to issue: n/a

@firstof9 firstof9 added breaking-change Change that will require user intervention code-quality Improves code quality or adds/updates tests labels Jul 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.26027% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.16%. Comparing base (8608d22) to head (113b852).
Report is 15 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #939      +/-   ##
==========================================
- Coverage   95.07%   93.16%   -1.92%     
==========================================
  Files           8        8              
  Lines        1482     1550      +68     
==========================================
+ Hits         1409     1444      +35     
- Misses         73      106      +33     
Files Coverage Δ
custom_components/mail_and_packages/__init__.py 92.55% <100.00%> (+0.44%) ⬆️
custom_components/mail_and_packages/const.py 100.00% <100.00%> (ø)
custom_components/mail_and_packages/helpers.py 92.61% <100.00%> (-2.11%) ⬇️
custom_components/mail_and_packages/config_flow.py 91.40% <95.83%> (-8.60%) ⬇️

... and 1 file with indirect coverage changes

@firstof9 firstof9 marked this pull request as ready for review July 6, 2024 22:39
@firstof9 firstof9 merged commit dc995d5 into moralmunky:dev Jul 6, 2024
5 checks passed
@firstof9 firstof9 deleted the amazon-config branch July 6, 2024 22:39
@spitfire
Copy link

spitfire commented Aug 5, 2024

I live in Poland and while I generally use amazon.pl, I sometimes order stuff from other European amazon sites (using the same account). Is there a way to configure multiple entries?

@firstof9
Copy link
Collaborator Author

firstof9 commented Aug 5, 2024

Is there a way to configure multiple entries?

Currently, you'd setup a second entry of the integration with another amazon domain. I'll see what I can do about using a list of domains so you only need a single configuration entry setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change that will require user intervention code-quality Improves code quality or adds/updates tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants