Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shipper): add more buildinglink subject lines #938

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

raccettura
Copy link

Encountered a few more that I missed the first time around. Mostly last-mile providers used by aliexpress and the like. The last one seems like a catch-all for anything not specifically in the system.

Encountered a few more that I missed the first time around.  Love how semi-consistent they are ;)
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.16%. Comparing base (8608d22) to head (a08bd07).
Report is 16 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #938      +/-   ##
==========================================
- Coverage   95.07%   93.16%   -1.92%     
==========================================
  Files           8        8              
  Lines        1482     1550      +68     
==========================================
+ Hits         1409     1444      +35     
- Misses         73      106      +33     
Files Coverage Δ
custom_components/mail_and_packages/const.py 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

@firstof9 firstof9 added bugfix Pull request to fix a bug shipper Request to add/modify a shipper labels Jul 6, 2024
@firstof9 firstof9 changed the title Some more buildinglink subject lines fix(shipper): add more buildinglink subject lines Jul 6, 2024
delivery has arrived
Copy link
Collaborator

@firstof9 firstof9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@firstof9 firstof9 merged commit b3897d8 into moralmunky:dev Jul 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request to fix a bug shipper Request to add/modify a shipper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants