Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch to proper reconfig flow #936

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

firstof9
Copy link
Collaborator

@firstof9 firstof9 commented Jul 5, 2024

Breaking change

Use the new reconfigure flow as of HA 2024.4.x

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

@firstof9 firstof9 added breaking-change Change that will require user intervention code-quality Improves code quality or adds/updates tests labels Jul 5, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 38.23529% with 21 lines in your changes missing coverage. Please review.

Project coverage is 91.24%. Comparing base (8608d22) to head (d2d5be8).
Report is 14 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #936      +/-   ##
==========================================
- Coverage   95.07%   91.24%   -3.84%     
==========================================
  Files           8        8              
  Lines        1482     1507      +25     
==========================================
- Hits         1409     1375      -34     
- Misses         73      132      +59     
Files Coverage Δ
custom_components/mail_and_packages/__init__.py 91.48% <100.00%> (-0.62%) ⬇️
custom_components/mail_and_packages/config_flow.py 75.00% <25.00%> (-25.00%) ⬇️

... and 2 files with indirect coverage changes

@firstof9 firstof9 marked this pull request as ready for review July 5, 2024 02:20
@firstof9 firstof9 merged commit 5bf4fbc into moralmunky:dev Jul 5, 2024
5 checks passed
@firstof9 firstof9 deleted the reconfig-flow branch July 5, 2024 02:20
firstof9 added a commit to firstof9/Home-Assistant-Mail-And-Packages that referenced this pull request Jul 5, 2024
* refactor: switch to proper reconfig flow

* update tests, remove commented code

* linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change that will require user intervention code-quality Improves code quality or adds/updates tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants