Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle more errors with mailbox listing #935

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

firstof9
Copy link
Collaborator

@firstof9 firstof9 commented Jul 3, 2024

Proposed change

Fix bool error message in config flow.
Handle more errors with mailbox listing.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation update
  • Adds a new shipper
  • Update existing shipper

Additional information

@firstof9 firstof9 added the bugfix Pull request to fix a bug label Jul 3, 2024
@firstof9 firstof9 marked this pull request as ready for review July 3, 2024 23:08
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.19%. Comparing base (8608d22) to head (4b227f2).
Report is 13 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #935      +/-   ##
==========================================
- Coverage   95.07%   94.19%   -0.88%     
==========================================
  Files           8        8              
  Lines        1482     1534      +52     
==========================================
+ Hits         1409     1445      +36     
- Misses         73       89      +16     
Files Coverage Δ
custom_components/mail_and_packages/config_flow.py 98.31% <25.00%> (-1.69%) ⬇️

... and 2 files with indirect coverage changes

@firstof9 firstof9 merged commit 4f5fdb9 into moralmunky:dev Jul 4, 2024
5 checks passed
firstof9 added a commit to firstof9/Home-Assistant-Mail-And-Packages that referenced this pull request Jul 5, 2024
* handle more errors with mailbox listing

* formatting

* refactor: clean up code that did nothing

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request to fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants