images: ignore bad image uris (Fixes #364) #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why on earth does this fail here but not on my machine. |
jodal
approved these changes
Oct 21, 2023
kingosticks
force-pushed
the
fix/bad-image-uri
branch
from
43efdf6
to
4f80d52
Compare
make the body longer....
304 response cannot set a body
|
Problem was setting the response body when the response status is 304. I've still no idea why I couldn't reproduce this on my local setup, must be a version mismatch but the packages for requests and responses were the same. |
kingosticks
added a commit
to kingosticks/mopidy-spotify
that referenced
this pull request
Dec 20, 2023
images: ignore bad image uris (Fixes mopidy#364) 304 response cannot set a body Improve test_cache_expired_with_etag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.