Make thread-safe, retain cache despite refresh #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3nprob
force-pushed
the
improve_startup_performance
branch
2 times, most recently
from
64b7c59
to
4fd8afe
Compare
kingosticks
reviewed
Jun 16, 2022
|
Sorry, I totally forgot to take a look. Will do this week. |
|
It took me a while... for which I am sorry but this was useful and I based #382 on this. Closing in favour of the updated PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at making #312 thread-safe.
Also:
force_refreshparameter to webclient and use it to remove the need for cache-wiping on refresh