Skip to content

Commit

Permalink
remove username and password config settings
Browse files Browse the repository at this point in the history
  • Loading branch information
kingosticks committed Sep 21, 2024
1 parent 1fafee3 commit 5331db1
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 27 deletions.
29 changes: 9 additions & 20 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,12 @@ Status :warning:
=================

Spotify have recently disabled username and password login for playback
(`#394 <https://github.com/mopidy/mopidy-spotify/issues/394>`_).
Alternate authentication methods are possible but not yet supported.
(`#394 <https://github.com/mopidy/mopidy-spotify/issues/394>`_) and we
now utilise access-token login. You no longer need to provide your
Spotify account password.

Mopidy-Spotify currently has no support for the following:

- Playback

- Seeking

- Gapless playback
Expand All @@ -48,6 +47,8 @@ Mopidy-Spotify currently has no support for the following:

Working support for the following features is currently available:

- Playback

- Search

- Playlists (read-only)
Expand All @@ -63,18 +64,9 @@ Dependencies
- A Spotify Premium subscription. Mopidy-Spotify **will not** work with Spotify
Free, just Spotify Premium.

- A non-Facebook Spotify username and password. If you created your account
through Facebook you'll need to create a "device password" to be able to use
Mopidy-Spotify. Go to http://www.spotify.com/account/set-device-password/,
login with your Facebook account, and follow the instructions. However,
sometimes that process can fail for users with Facebook logins, in which case
you can create an app-specific password on Facebook by going to facebook.com >
Settings > Security > App passwords > Generate app passwords, and generate one
to use with Mopidy-Spotify.

- ``Mopidy`` >= 3.4. The music server that Mopidy-Spotify extends.

- ``gst-plugins-spotify`` >= 0.10. The `GStreamer Rust Plugin
- A *custom* version of ``gst-plugins-spotify``. The `GStreamer Rust Plugin
<https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs>`_ to stream Spotify
audio, based on `librespot <https://github.com/librespot-org/librespot/>`_.
**This plugin is not yet available from apt.mopidy.com**. It must be either
Expand All @@ -83,6 +75,9 @@ Dependencies
or `Debian packages are available
<https://github.com/kingosticks/gst-plugins-rs-build/releases/latest>`_
for some platforms.
**We currently require a forked version of ``gst-plugins-spotify`` which supports
token-based login. This can be found `here
<https://gitlab.freedesktop.org/kingosticks/gst-plugins-rs/-/tree/0.13-librespot-dev>`_.
Verify the GStreamer spotify plugin is correctly installed::

Expand All @@ -106,8 +101,6 @@ https://mopidy.com/ext/spotify/#authentication
to authorize this extension against your Spotify account::

[spotify]
username = alice
password = secret
client_id = ... client_id value you got from mopidy.com ...
client_secret = ... client_secret value you got from mopidy.com ...

Expand All @@ -116,10 +109,6 @@ The following configuration values are available:
- ``spotify/enabled``: If the Spotify extension should be enabled or not.
Defaults to ``true``.

- ``spotify/username``: Your Spotify Premium username. You *must* provide this.

- ``spotify/password``: Your Spotify Premium password. You *must* provide this.

- ``spotify/client_id``: Your Spotify application client id. You *must* provide this.

- ``spotify/client_secret``: Your Spotify application secret key. You *must* provide this.
Expand Down
3 changes: 0 additions & 3 deletions src/mopidy_spotify/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ def get_default_config(self):
def get_config_schema(self):
schema = super().get_config_schema()

schema["username"] = config.String()
schema["password"] = config.Secret()

schema["client_id"] = config.String()
schema["client_secret"] = config.Secret()

Expand Down
2 changes: 0 additions & 2 deletions src/mopidy_spotify/ext.conf
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
[spotify]
enabled = true
username =
password =
client_id =
client_secret =
bitrate = 160
Expand Down
2 changes: 0 additions & 2 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ def config(tmp_path):
},
"proxy": {},
"spotify": {
"username": "alice",
"password": "password",
"bitrate": 160,
"volume_normalization": True,
"timeout": 10,
Expand Down

0 comments on commit 5331db1

Please sign in to comment.