Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort fields properly #259

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

alovak
Copy link
Contributor

@alovak alovak commented Jul 31, 2023

This PR fixes the issue with converting subfield indexes (map keys) into int to sort them as ints and then convert them back to string so we can use them as keys for the map.

The issue happened when key 01 (string) converted into 1 (int) and then into 1 (string). Code panic with invalid memory address or nil pointer dereference.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (36606f8) 73.49% compared to head (78ade2f) 73.50%.

❗ Current head 78ade2f differs from pull request most recent head 545fc16. Consider uploading reports for the commit 545fc16 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   73.49%   73.50%   +0.01%     
==========================================
  Files          43       43              
  Lines        2290     2291       +1     
==========================================
+ Hits         1683     1684       +1     
- Misses        375      377       +2     
+ Partials      232      230       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alovak alovak requested a review from adamdecaf July 31, 2023 19:11
@alovak alovak merged commit a0db8ac into master Jul 31, 2023
6 checks passed
@alovak alovak deleted the fix-issue-with-numeric-index-for-composite-fields branch July 31, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants