Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip bitmap presence bits when pack and unpack message #255

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

alovak
Copy link
Contributor

@alovak alovak commented Jul 25, 2023

closes #254

This PR adds the IsBitmapPresenceBit method to the Bitmap, allowing us to ignore fields that have the same index as bits, which indicate the presence of the next bitmap. By using this method, we can skip these fields when packing and unpacking a message.

@alovak alovak changed the title Fix unpacking bitmap fields Skip bitmap presence bits when pack and unpack message Jul 25, 2023
@alovak
Copy link
Contributor Author

alovak commented Jul 25, 2023

this PR does not fix the same issue for composites. I'll fix it as well.

@alovak alovak mentioned this pull request Jul 25, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 71.42% and project coverage change: +0.05% 🎉

Comparison is base (026d31c) 73.43% compared to head (5d4c821) 73.48%.

❗ Current head 5d4c821 differs from pull request most recent head c324965. Consider uploading reports for the commit c324965 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   73.43%   73.48%   +0.05%     
==========================================
  Files          43       43              
  Lines        2270     2282      +12     
==========================================
+ Hits         1667     1677      +10     
- Misses        373      374       +1     
- Partials      230      231       +1     
Files Changed Coverage Δ
field/composite.go 83.22% <60.00%> (ø)
field/bitmap.go 71.05% <75.00%> (+0.29%) ⬆️
message.go 71.30% <100.00%> (+0.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alovak alovak merged commit 8a4812a into master Jul 25, 2023
6 checks passed
@alovak alovak deleted the fix-unpacking-bitmap-fields branch July 25, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for third bitmap
3 participants