Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check nil on fmt stringer #333

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Check nil on fmt stringer #333

merged 3 commits into from
Oct 26, 2023

Conversation

kolaworld
Copy link
Contributor

  • Prevent panic when calling log.Stringer(nil)

log/model_valuer.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9148cd) 76.78% compared to head (52c0b8a) 76.83%.

❗ Current head 52c0b8a differs from pull request most recent head 3c23cdb. Consider uploading reports for the commit 3c23cdb to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   76.78%   76.83%   +0.04%     
==========================================
  Files          28       28              
  Lines        1034     1036       +2     
==========================================
+ Hits          794      796       +2     
  Misses        178      178              
  Partials       62       62              
Files Coverage Δ
log/model_valuer.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kolaworld kolaworld merged commit 967cfe2 into master Oct 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants