Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Moonbase] Enable pallet-xcm precompile #2803

Merged
merged 10 commits into from
May 20, 2024
Merged

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented May 15, 2024

What does it do?

Adds the pallet-xcm precompile from moonkit (introduced in Moonsong-Labs/moonkit#35) to Moonbase runtime.

TODO

  • Use proper moonkit branch

@Agusrodri Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. breaking Needs to be mentioned in breaking changes labels May 15, 2024
Copy link
Contributor

github-actions bot commented May 15, 2024

Coverage Report

@@                    Coverage Diff                     @@
##           master   agustin-xcm-precompile      +/-   ##
==========================================================
+ Coverage   73.06%                   73.08%   +0.02%     
  Files         228                      228              
- Lines       69944                    69930      -14     
==========================================================
+ Hits        51103                    51105       +2     
- Misses      18841                    18825      -16     
Files Changed Coverage
/precompiles/utils/macro/src/precompile_name_from_address.rs 82.83% (+2.02%) 🔼

Coverage generated Fri May 17 17:48:52 UTC 2024

@Agusrodri Agusrodri marked this pull request as ready for review May 17, 2024 13:27
runtime/common/src/weights/pallet_xcm.rs Outdated Show resolved Hide resolved
runtime/moonbase/src/precompiles.rs Outdated Show resolved Hide resolved
runtime/moonbase/src/precompiles.rs Outdated Show resolved Hide resolved
RomarQ
RomarQ previously approved these changes May 17, 2024
@Agusrodri Agusrodri merged commit f2cd74e into master May 20, 2024
27 checks passed
@Agusrodri Agusrodri deleted the agustin-xcm-precompile branch May 20, 2024 02:34
@noandrea noandrea added not-breaking Does not need to be mentioned in breaking changes and removed breaking Needs to be mentioned in breaking changes labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants