Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce skipped tests down to zero #110

Open
stronk7 opened this issue Oct 5, 2019 · 6 comments
Open

Reduce skipped tests down to zero #110

stronk7 opened this issue Oct 5, 2019 · 6 comments

Comments

@stronk7
Copy link
Member

stronk7 commented Oct 5, 2019

The main point of this issue is to track moodlehq/moodle-ci-runner#15 , where we are aiming to reduce the skipped tests down to 0. And apply the corresponding changes here. Namely we'll need, right now:

  • mlbackend-python (now that it can be used via server).
  • unoconv
  • uuid
  • scss compiler
@scara
Copy link
Contributor

scara commented Oct 6, 2019

Hi @stronk7,
do you have already a plan for each task?

@stronk7
Copy link
Member Author

stronk7 commented Oct 6, 2019

Nope,

  • for the mlbackend-python I count with @dmonllao , he already has a docker image that we just need to add to moodlehq (MDL-66004) and keep it self-updated. Then we'll add it both here and to moodle-ci-runner (sort of related with Install python and moodlemlbackend package moodle-php-apache#35 , but not 100% about what will happen with the local server there).
  • unoconv is really tricky, because it's huge, right now I don't remember its abilities to run in server mode...
  • uuid shouldn't be hard (it's just an extension, although, again, have to refresh my knowledge, as far as there were 2 different extensions and somehow it's all mixed in my brain right now.
  • and scss compiler should be trivial, as far as it's already bundled in the php images and there is As far as sassc is available in all images... enable it for phpunit runs #94 about it.

That's the super-summary as I see it now.

Ciao :-)

@scara
Copy link
Contributor

scara commented Oct 6, 2019

Hi Eloy,

  1. I'm following MDL-66004 and related
  2. unoconv could run in server mode i.e. it means we need to add a new service in the docker compose
  3. just one ext: MDL-61038, in the testing instruction you'll find what required - just one new package - to install the PECL one
  4. I missed that issue: will (better) follow it

If you need some help for some PR and/or peer review, here I am ;).

HTH,
Matteo

@stronk7
Copy link
Member Author

stronk7 commented Oct 6, 2019

Aha,

  1. nice... it sounded to me but was not 100% sure. Cool!
  2. perfect!

About helping, as you can/wish, @scara . Any contribution is really welcome, any time and, specially, over the next weeks that we are furiously working/busy to get 3.8 well cooked. That reduces our capability to after-hours/weekends basically.

But not pressure, you know, just when/if you can. Thanks for all the collaboration with all this stuff, much appreciated!

Ciao :-)

@stronk7
Copy link
Member Author

stronk7 commented Oct 9, 2019

  1. uuid should be done with the 6 PRs linked above (for php 71, 72, 73, both stretch and buster)

So, remaining:

  1. mlbackend-python
  2. unoconv
  3. scss compiler (As far as sassc is available in all images... enable it for phpunit runs #94).

@dmonllao
Copy link

dmonllao commented Dec 5, 2019

#113 for mlbackend-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants