Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing services to reduce (down to 0) the skipped tests #15

Open
stronk7 opened this issue Oct 5, 2019 · 7 comments
Open

Add missing services to reduce (down to 0) the skipped tests #15

stronk7 opened this issue Oct 5, 2019 · 7 comments

Comments

@stronk7
Copy link
Member

stronk7 commented Oct 5, 2019

This issue is about to reduce the number of skipped tests with phpunit. Namely:

Basically, that's all we need to get all tests passing. Let's use this issue as epic to control it.

Ciao :-)

@stronk7
Copy link
Member Author

stronk7 commented Oct 5, 2019

Have just added 4 PRs that should be merged in order:

#11 - tiny change to better detect the script directory. Same approach we use in a lot of local_ci scripts, enable you to wrap it in other, caller scripts...
#12 - enable solr.
#13 - enable memcached.
#14 - enable mongodb

Ciao :-)

PS: Have just launched this with all the above applied (testing branch). There should be only mlbackend, unoconv and uuid skipped tests once it finishes.

Build Status

Edited, yay! Down from 51 skipped tests to only 13!

@andrewnicols
Copy link
Collaborator

All looking good and merged \o/
Win! Nice work Eloy.

@stronk7
Copy link
Member Author

stronk7 commented Oct 9, 2019

Thanks for merging, @andrewnicols !

If you don't mind, I'm going to keep this open to take a look to the pending stuff:

  • mlbackend-python. Now that the python backend can run via server (MDL-66004)... we can add it to the runner. Worth discussing about adopting and automating the managing of that image with @dmonllao .
  • uuid
  • unoconv

And linking this with moodlehq/moodle-docker#110 that is aiming for exactly the same, but from moodle-docker.

@stronk7
Copy link
Member Author

stronk7 commented Oct 9, 2019

With the 6 PRs above all our (non-EOL) images should get uuid tests passing.

So, remaining:

  • mlbackend-python
  • unoconv

Ciao :-)

@stronk7
Copy link
Member Author

stronk7 commented Apr 5, 2022

With #73 merged, now the only remaining tests are:

  • unoconv

Ciao :-)

@stronk7
Copy link
Member Author

stronk7 commented Dec 5, 2022

Uhm... was revisiting this to see if finally can get it closed... and I've just seen that phpunit is still skipping the mlbackend_python tests:

https://ci.moodle.org/view/B%20-%20master/job/W.01.01%20-%20PHPUnit%20-%20Postgres/2183/console

I thought we were running them... looking...

@stronk7
Copy link
Member Author

stronk7 commented Dec 6, 2022

^^^ False alarm, they are supported and running. But we only run them within the MariaDB jobs (see those jobs are named:
W.XX.YY - PHPUnit - MariaDB (lowest + mlbackend)

So, only remaining test continues being:

  • unoconv

Ciao :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants