Add test for multiline attributes for MissingDocblockSniff on methods…

… outside of classes
moodlehq · Sep 19, 2024 · 6d83352 · 6d83352
1 parent 89ff0ac
commit 6d83352
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/moodle/Tests/Sniffs/Commenting/MissingDocblockSniffTest.php b/moodle/Tests/Sniffs/Commenting/MissingDocblockSniffTest.php
@@ -231,10 +231,11 @@ public static function docblockCorrectnessProvider(): array {
                 'fixture' => 'docblock_with_multiline_attributes',
                 'fixtureFilename' => null,
                 'errors' => [
-                    59 => 'Missing docblock for class class_multiline_attribute_space_between',
-                    69 => 'Missing docblock for function method_multiline_attribute_space_between',
-                    81 => 'Missing docblock for interface interface_multiline_attribute_space_between',
-                    92 => 'Missing docblock for trait trait_multiline_attribute_space_between',
+                    69 => 'Missing docblock for class class_multiline_attribute_space_between',
+                    79 => 'Missing docblock for function method_multiline_attribute_space_between',
+                    91 => 'Missing docblock for function single_method_multiline_attribute_space_between',
+                    102 => 'Missing docblock for interface interface_multiline_attribute_space_between',
+                    113 => 'Missing docblock for trait trait_multiline_attribute_space_between',
                 ],
                 'warnings' => [],
             ];

diff --git a/...e/Tests/Sniffs/Commenting/fixtures/MissingDocblock/docblock_with_multiline_attributes.php b/...e/Tests/Sniffs/Commenting/fixtures/MissingDocblock/docblock_with_multiline_attributes.php
@@ -28,6 +28,16 @@ function method_multiline_attribute(): void {
     }
 }
 
+/*
+ * Function with multiline attributes.
+ */
+#[someattribute(
+    attr1: 'asdf',
+    attr2: 'asdf',
+)]
+function single_method_multiline_attribute(): void {
+}
+
 /**
  * Interface with multiline attributes.
  */
@@ -70,6 +80,17 @@ function method_multiline_attribute_space_between(): void {
     }
 }
 
+/*
+ * Function with multiline attributes and space between.
+ */
+
+#[someattribute(
+    attr1: 'asdf',
+    attr2: 'asdf',
+)]
+function single_method_multiline_attribute_space_between(): void {
+}
+
 /**
  * Interface with multiline attributes.
  */