Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add id field to each item #369

Closed
wants to merge 2 commits into from

Conversation

blaine-arcjet
Copy link
Contributor

This is a big change so I'm welcome to any feedback!

I'd like to add an id field to each item that gives sort of a common identifier to each item.

This can be use to uniquely identify which pattern(s) matched a particular user agent.

Many of the IDs are just nameofcompany-crawler but I also have monitor and validator for tools that help with those things.

@monperrus
Copy link
Owner

thanks for the proposal.

the pattern itself is the identifier, I would not go into this additional maintenance complexity

@blaine-arcjet
Copy link
Contributor Author

blaine-arcjet commented Sep 6, 2024

Okay. I need this ID for a some projects so if we don't include it in this upstream repo, I'll have to commit to a complete fork ☹️ but I understand.

@davidmytton davidmytton deleted the phated/add-id branch September 7, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants