Add and use requirements.txt
#357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `requirements.txt` file to pin dependencies, direct and transitive. This was achieved by, in a clean Docker image, first running `pip3 freeze` to get irrelevant packages, then running the existing `pip3 install` (from CI) command, and then running `pip3 freeze` again to get this project's dependencies. Both CIs have been updated to use the requirements.txt file to install dependencies. Besides improving reproducibility, this also avoids duplication. The benefit of doing this is that the same versions of Python dependencies will always be used for this project. If the registry is trusted you can also be sure that the same source code is always run (the absence of local checksums means this isn't the case if the registry isn't trusted).
|
thanks a lot @ericcornelissen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I'm not very experienced with Python dependency management and pip. My goal here is similar to #351 but for pip.
This adds a
requirements.txtfile to pin Python dependencies, direct and transitive. This was achieved by, in a clean Docker image, first runningpip3 freezeto get a list of irrelevant packages, then running the existingpip3 install jsonschema pytest(from CI) command, and finally runningpip3 freezeagain to get this project's dependencies (by omitting those from the firstpip3 freezelist).Both CIs have been updated to use the
requirements.txtfile to install dependencies. Besides improving reproducibility, this also avoids duplication.The benefit of doing this is that the same versions of Python dependencies will always be used for this project (assuming pip respects the requirements). If the registry is trusted you can also be sure that the same source code is always run (however the absence of local checksums means this isn't the case if the registry isn't trusted).