Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape dots in patterns #338

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Escape dots in patterns #338

merged 3 commits into from
Apr 4, 2024

Conversation

giuscris
Copy link
Contributor

Thank you @monperrus for this repository.

I've noticed that several patterns contain unescaped dots, causing false positives.
I fixed these patterns and added a check to validate.py to ensure they're properly escaped.

@monperrus
Copy link
Owner

Thanks @giuscris

The one reason dot is good is that you can string-match with them, in case your platform has no support for regexp or you care for speed.

@giuscris
Copy link
Contributor Author

Yes, of course you can string-match but some patterns are already regular expressions. It would be a partial match in any case.

@monperrus
Copy link
Owner

you're right. Maybe we should have pattern (mandatory) and pattern_regexp (optional) and change the CI validation script accordingly.

@doublex
Copy link

doublex commented Jan 25, 2024

+1
Works for me

@monperrus monperrus merged commit 36ce640 into monperrus:master Apr 4, 2024
2 checks passed
@monperrus
Copy link
Owner

thanks a lot @giuscris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants