Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quotes): invalid chars, general format (@syndric) #5810

Closed
wants to merge 4 commits into from

Conversation

Syndric
Copy link

@Syndric Syndric commented Aug 20, 2024

Description

Removal of all non-essential JSON fields

Filters applied:

Non-code Text:

  • Fancy double quotes to regular double quotes
  • Fancy single quotes to single double quotes
  • Single char ... to triple char ...
  • Both fancy dash variants to regular dash
  • 2+ spaces in a row to single space
  • x2 single/double quotes back to back
  • All hanging spaces at the beginning/end of text
  • Lengths verified

Code text:

  • All hanging spaces at the beginning/end of text
  • Lengths verified

Source:

  • All hanging spaces at the beginning/end of text

Program used to load quotes and apply filters found here

Checks

  • [] Adding quotes?
    • [] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Aug 20, 2024
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@Miodec
Copy link
Member

Miodec commented Aug 23, 2024

Im not sure how i feel about this PR. The diff is huge, and most of the changes are already handled during word generation...

@Syndric
Copy link
Author

Syndric commented Aug 23, 2024

I see. If there's nothing you want to keep, you can close the PR

@Miodec
Copy link
Member

Miodec commented Aug 23, 2024

Yeah, sorry. Thanks for the pr though. I would recommend discussing any large changes like that.

@Miodec Miodec closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants