Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2789 Convert DNS Seedlist Spec to Markdown #1538

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 6, 2024

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@blink1073 blink1073 requested review from a team as code owners March 6, 2024 11:02
@blink1073 blink1073 requested review from JamesKovacs, jess-sig and NoahStapp and removed request for a team, JamesKovacs and jess-sig March 6, 2024 11:02
@@ -115,6 +116,7 @@
with open(md_file, 'w') as fid:
fid.write('\n'.join(new_lines))


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded space?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

…ce/initial-dns-seedlist-discovery/tests/README.md
…covery.rst to source/initial-dns-seedlist-discovery/initial-dns-seedlist-discovery.md
further fixes for migration script

remove space
@blink1073 blink1073 merged commit 345c243 into mongodb:master Mar 6, 2024
4 checks passed
@blink1073 blink1073 deleted the DRIVERS-2789-initial-dns branch March 6, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants