Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-272416: Remove datalake tests #3252

Merged
merged 4 commits into from
Sep 10, 2024
Merged

CLOUDP-272416: Remove datalake tests #3252

merged 4 commits into from
Sep 10, 2024

Conversation

blva
Copy link
Collaborator

@blva blva commented Sep 10, 2024

Proposed changes

Jira ticket: CLOUDP-272416

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva requested a review from a team as a code owner September 10, 2024 16:14
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the deprecation please, specially since we'll release this week

jeroenvervaeke
jeroenvervaeke previously approved these changes Sep 10, 2024
@blva
Copy link
Collaborator Author

blva commented Sep 10, 2024

@gssbzn covering deprecation in the deprecation task and fixing the test failures here.

@blva
Copy link
Collaborator Author

blva commented Sep 10, 2024

also: currently

➜  mongodb-atlas-cli git:(master) ./bin/atlas datalake
Command "dataLakes" is deprecated, Please use 'atlas datafederation'
The datalakes command provides access to your project data lakes. You can create, edit, and delete data lakes.

Usage:

@blva blva requested a review from gssbzn September 10, 2024 16:25
@gssbzn
Copy link
Collaborator

gssbzn commented Sep 10, 2024

/bin/atlas datalake

that's datalake which is actually atlas dataFederation, you need to deprecate atlas dataLakePipelines

@blva blva requested a review from a team as a code owner September 10, 2024 16:28
@github-actions github-actions bot added the need-doc-review Improvements or additions to documentation, will be reviewed by the docs team label Sep 10, 2024
gssbzn
gssbzn previously approved these changes Sep 10, 2024
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

APIx Bot :bowtie:: a message has been sent to Docs Slack channel 🚀.

@blva blva merged commit ed72504 into master Sep 10, 2024
17 of 19 checks passed
@blva blva deleted the CLOUDP-272416 branch September 10, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-doc-review Improvements or additions to documentation, will be reviewed by the docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants