CLOUDP-268553: Add warning for docker engine/podman minimum versions #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenezes
reviewed
Sep 5, 2024
| var errParseHealthCheck = errors.New("parsing image healthcheck failed") | ||
| var errListContainer = errors.New("container listing failed") | ||
| var errParsingContainer = errors.New("container parsing failed") | ||
| var errDecodingJSON = errors.New("container decoding failed") | ||
| var errParsingPorts = errors.New("parsing ports failed") | ||
| var errConvertHostPort = errors.New("converting host port failed") | ||
| var errConvertContainerPort = errors.New("converting container port failed") | ||
| var minDockerVersion = semver.New(27, 0, 0, "", "") //nolint:mnd |
There was a problem hiding this comment.
Our promise is the last two, so I would stick 26
There was a problem hiding this comment.
27.0+ is what the docs say. Should we update the docs too?
There was a problem hiding this comment.
There was a problem hiding this comment.
yes our current epic (linux stability) will update the docs
There was a problem hiding this comment.
discussed offline, let's keep only the latest
fmenezes
reviewed
Sep 5, 2024
internal/podman/client.go
Outdated
| ErrPodmanNotFound = errors.New("podman not found in your system, check requirements at https://dochub.mongodb.org/core/atlas-cli-deploy-local-reqs") | ||
| ErrPodmanNotFound = errors.New("podman not found in your system, check requirements at https://dochub.mongodb.org/core/atlas-cli-deploy-local-reqs") | ||
| ErrDeterminingPodmanVersion = errors.New("could not determine docker version") | ||
| minPodmanVersion = semver.New(5, 2, 0, "", "") //nolint:mnd |
There was a problem hiding this comment.
you can check with Ciprian but I think we need to support latest two majors, which would mean v4.9 minimum
fmenezes
previously approved these changes
Sep 5, 2024
fmenezes
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add warning for docker engine/podman minimum versions.
Jira ticket: CLOUDP-268553
Testing