Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change string method name to text #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mt-kelvintaywl
Copy link

description

just a thought, but
I was just thinking perhaps text as a method name would be more 'human' / layman ! :)

since it'd now be text, domain, email 🤓

@mt-sergio
Copy link

I added a minimum protection to avoid merging without approvals.

Copy link

@m13 m13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I prefer @mt-ronkorving approving it
Ups! This is my personal account.

@mt-ronkorving
Copy link
Collaborator

mt-ronkorving commented Jan 14, 2020

I'm gonna let this sit here for a while if you don't mind. Need to think about this in the bigger picture of the library (there is one ;)). See also #4

@mt-kelvintaywl
Copy link
Author

SGTM :) i understand the motivations for #4 as well 👍 looking forward to the developments of this library 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants