Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

NetDb: refactoring + traits #644

Merged
merged 4 commits into from
May 23, 2017
Merged

NetDb: refactoring + traits #644

merged 4 commits into from
May 23, 2017

Conversation

anonimal
Copy link
Collaborator

WIP. Referencing #643 and #450.

By submitting this pull-request, I confirm the following:

  • I have read and understood the Contributing Guide.
  • I have checked that another pull-request for this purpose does not exist.
  • I have considered and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used and that this pull-request may be closed by the will of the maintainer.
  • I give this submission freely under the BSD 3-clause license.

@anonimal
NetDb: create POD class NetDbTraits + refactoring
b590d0b 
- Current traits moved to POD class

- Refactors/simplifies enumerations
  * Enumerations now scoped at class level
    - Removes voracious static_cast usage (see monero-project#450)
  * Moves all time-related enumerators to Time enum
    - Remove Interval enum
  * Enumerator name refactor for clarity

- Fixes/cleans-up documentation
@anonimal
NetDb: enumerate minimum required routers
4fc1dec
@anonimal
NetDb: integer type refactor + related refactoring
ce2ddbc 
- Use appropriate unsigned types
- Zero-initialize integer arrays
- Related logic refactor
@anonimal
NetDb: remove unnecessary null terminators
1d8d8cd
@anonimal anonimal merged commit 1d8d8cd into monero-project:master May 23, 2017
anonimal added a commit that referenced this pull request May 23, 2017
@anonimal
Merge pull request #644
21f7dd0 
1d8d8cd NetDb: remove unnecessary null terminators (anonimal)
ce2ddbc NetDb: integer type refactor + related refactoring (anonimal)
4fc1dec NetDb: enumerate minimum required routers (anonimal)
b590d0b NetDb: create POD class NetDbTraits + refactoring (anonimal)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anonimal