Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

NetDb: rewrite/refactor #643

Closed
anonimal opened this issue May 19, 2017 · 1 comment
Closed

NetDb: rewrite/refactor #643

anonimal opened this issue May 19, 2017 · 1 comment
Assignees
@anonimal
Labels
libcore maintenance major

Comments

@anonimal
Copy link
Collaborator

Not nearly as bad of shape as #627 was and as #511 currently is, the network-database has always needed work (but this issue is mostly for housekeeping).

Since NetDb/RI/I2NP/Tunnels/Transports are all related (too closely related in our implementation), any work here will help clarify any questions / resolve any potential issues related to #187.

By submitting this issue, I confirm the following:

  • I have read and understood the contributor guide.
  • I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
  • I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.
@anonimal anonimal self-assigned this May 19, 2017
@anonimal anonimal mentioned this issue May 19, 2017
Merged
@anonimal anonimal mentioned this issue Dec 8, 2017
Closed
@anonimal anonimal added this to the 0.1.0-alpha milestone Jan 25, 2018
This was referenced Feb 8, 2018
Merged
Closed
@coneiric coneiric mentioned this issue Jun 16, 2018
Merged
coneiric added a commit to coneiric/kovri that referenced this issue Jun 26, 2018
@coneiric
NetDb: exclude routers before sorting them
57332bb 
It is unnecessary to sort excluded routers.

References monero-project#643 and monero-project#910
coneiric added a commit to coneiric/kovri that referenced this issue Jun 26, 2018
@coneiric
NetDb: add lock in getting closest non-floodfill
eca1128 
References monero-project#643 and monero-project#910
coneiric added a commit to coneiric/kovri that referenced this issue Jun 26, 2018
@coneiric
Exception: make Dispatch const-correct
bbdf271 
References monero-project#643 and monero-project#910
coneiric added a commit to coneiric/kovri that referenced this issue Jun 26, 2018
@coneiric
NetDb: catch exceptions getting closest routers
06d4f0b 
References monero-project#643 and monero-project#910
coneiric added a commit to coneiric/kovri that referenced this issue Jun 26, 2018
@coneiric
Test: NetDb get closest routers unit-tests
4ea811c 
References monero-project#643 and monero-project#910
coneiric added a commit to coneiric/kovri that referenced this issue Jun 26, 2018
@coneiric
NetDb: adds const-correctness + default params
32ebf5d 
Adds const-correctness to getting closest router parameters, and
default parameters for excluded routers.

Credit to anonimal for the patch.

Referencing monero-project#643 and monero-project#910
coneiric added a commit to coneiric/kovri that referenced this issue Jun 26, 2018
@coneiric
Tests: patches NetDb closest router unit-tests
e9d2bf4 
Cleaner, more useable NetDb test fixture, and more concise test cases.

Credit to anonimal for the patch.

References monero-project#643 and monero-project#910
@anonimal anonimal removed this from the 0.1.0-alpha milestone Jun 28, 2018
@anonimal
Copy link
Collaborator Author

anonimal commented Sep 7, 2018

NOTICE: THIS ISSUE HAS BEEN MOVED TO GitLab. Please continue the discussion there. See #1013 for details.

@anonimal anonimal closed this as completed Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anonimal anonimal

Labels
libcore maintenance major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anonimal