Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use collections API for state management #10

Merged
merged 1 commit into from
Sep 27, 2024
Merged

refactor: use collections API for state management #10

merged 1 commit into from
Sep 27, 2024

Conversation

spoo-bar
Copy link
Contributor

@spoo-bar spoo-bar commented Sep 24, 2024 •
edited
Loading

  • Modify all state access keeper methods to use Collections API instead of directly operating on the KV Store.
  • Remove the prefix helper funcs from types/keys.go

@spoo-bar spoo-bar marked this pull request as ready for review September 24, 2024 07:39
@johnletey johnletey mentioned this pull request Sep 24, 2024
Closed
6 tasks
@johnletey johnletey force-pushed the spoorthi/collections-2 branch 2 times, most recently from a780941 to c7cda16 Compare September 27, 2024 11:04
@johnletey @spoo-bar @g-luca
refactor: utilize collections for state management
12ecf71 
Co-authored-by: Spoorthi <[email protected]>
Co-authored-by: Luca Graziotti <[email protected]>
gislik
gislik approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@gislik gislik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🙌

@gislik gislik merged commit 8a55981 into monerium:main Sep 27, 2024
1 check passed
@johnletey johnletey deleted the spoorthi/collections-2 branch September 27, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gislik gislik gislik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spoo-bar @gislik @johnletey