Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disease_by_gene pattern #7277

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

sabrinatoro
Copy link
Collaborator

Address #7271

The pattern OMIM_disease_series_by_gene refers to the variable "disease" as "MONDO:0000001", which is the parent term of "human disease" and "non-human disease".
Therefore, this pattern could be used for both genetic diseases for human (from OMIM) and non-human animal (from OMIA).

I updated the existing description to reflect the above.
Note that I did not rename the pattern because it has been used "everywhere" in the ontology.

@matentzn @cmungall @katiermullen

Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont feel empowered to review this by FWIW LGTM.

series (OMIMPS), which are represented as grouping classes in Mondo. Notes about
the OMIMPS (see also OMIM_phenotypic_series.yaml): - every instance of the OMIMPS
series (OMIMPS), which are represented as grouping classes in Mondo, and (2) OMIA Mendelian diseases (https://omia.org/) which are defined by a variation in a gene.
Notes about the OMIMPS (see also OMIM_phenotypic_series.yaml): - every instance of the OMIMPS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new line before the "every instance"?

@matentzn matentzn marked this pull request as draft May 24, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants