ORDO docs updates #497
Merged
ORDO docs updates #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeflack4
commented
Apr 18, 2024
| @@ -71,3 +71,9 @@ comment: > | |||
| recorded in ORDO. This is why great care needs to be taking interpreting diesease 2 gene relationships during ingest! | |||
| base_prefix_map: | |||
| Orphanet: http://www.orpha.net/ORDO/Orphanet_ | |||
| comments_about_this_source: > | |||
There was a problem hiding this comment.
comments_about_this_source in ordo.yml
As decided in #481. The relevance of this will kick in moreso when that issue is completed.
|
This PR is a low priority but just wanted to get it out of my personal notes and into the pipeline. |
matentzn
requested changes
Apr 22, 2024
Fixed some typos Co-authored-by: Nico Matentzoglu <[email protected]>
Fixed some typos Co-authored-by: Nico Matentzoglu <[email protected]>
Added clarifying language Co-authored-by: Nico Matentzoglu <[email protected]>
Corrected typo and grammar Co-authored-by: Nico Matentzoglu <[email protected]>
Added clarifying language Co-authored-by: Nico Matentzoglu <[email protected]>
|
@matentzn Thanks for looking over the documentation and providing typo and grammar fixes, as well as adding some clarifying language. I have committed these suggestions! |
matentzn
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates ORDO docs:
docs/sources/SOURCE.mdtemplating & editing #481)Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingeston this branch (afterdocker pull obolibrary/odkfull:dev), and no errors occurred?New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?