Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pull_request_template.md #430

Merged
merged 14 commits into from
Feb 22, 2024
26 changes: 26 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
Fixes #ISSUE.
matentzn marked this conversation as resolved.
Show resolved Hide resolved

**No (!) PRs should be merged without at least one review from a different team member of the Mondo Technical team.**
matentzn marked this conversation as resolved.
Show resolved Hide resolved
matentzn marked this conversation as resolved.
Show resolved Hide resolved

## Pre-merge checklist
joeflack4 marked this conversation as resolved.
Show resolved Hide resolved

<!--- A common case for documentation is the addition of new `make` goals. Descriptions should be documented for new goals both in the (i) `help` command at the bottom of the `mondo-ingest.Makefile` and (ii) `docs/developer/workflows.md`. -->
matentzn marked this conversation as resolved.
Show resolved Hide resolved

- [ ] Docs
- `docs/` have been added/updated **OR**
- No updates to the docs necessary after careful consideration.

- [ ] QC
- `sh run.sh make build-mondo-ingest` has been run on this branch (after `docker pull obolibrary/odkfull:dev), and no errors occurred **OR**
- No functional (code-related) changes to the pipeline are suggested, so no re-run is necessary.

matentzn marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Reviewed
- Has been sufficiently reviewed by at least one review from a different team member of the Mondo Technical team.

## High-level description
matentzn marked this conversation as resolved.
Show resolved Hide resolved

matentzn marked this conversation as resolved.
Show resolved Hide resolved
This PR:

- One
- Two
- Three