-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #430 from monarch-initiative/matentzn-patch-3
Create pull_request_template.md
- Loading branch information
Showing
1 changed file
with
47 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
Resolves #ISSUE(s). | ||
<!--- "Resolves #ISSUE" will automatically close #ISSUE when the PR is merged. However, if this PR won't 100% address the issue, you can use one of these patterns instead to simply link to the issue and not auto-close it: | ||
Partially addresses: | ||
- ISSUE(s) | ||
Addresses sub-task (n) in: | ||
- ISSUE(s) | ||
--> | ||
|
||
|
||
## Pre-merge checklist | ||
|
||
<!--- Docs: A common case for documentation is the addition of new `make` goals. Descriptions should be documented for new goals both in the (i) `help` command at the bottom of the `mondo-ingest.Makefile` and (ii) `docs/developer/workflows.md`. --> | ||
|
||
### PR Overview | ||
<!--- Short paragraph or short bulleted list describing changes in this PR --> | ||
|
||
This PR: | ||
- One | ||
- Two | ||
- Three | ||
|
||
===================== | ||
### Documentation | ||
- Was the documentation added/updated under `docs/`? | ||
- [ ] Yes | ||
- [ ] No, updates to the docs were not necessary after careful consideration | ||
|
||
### QC | ||
- Was the full pipeline run before submitting this PR using `sh run.sh make build-mondo-ingest` on this branch (after `docker pull obolibrary/odkfull:dev`), and no errors occurred? | ||
- [ ] Yes | ||
- [ ] No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary | ||
|
||
### New Packages | ||
- Were any new *Python packages* added? | ||
- [ ] Yes, [requirements.txt.full](https://github.com/INCATools/ontology-development-kit/blob/master/requirements.txt.full) was updated and an [ODK issue](https://github.com/INCATools/ontology-development-kit/issues/new) submitted | ||
- [ ] No | ||
</br> | ||
|
||
- Were any other *non-Python packages* added? | ||
- [ ] Yes, [Dockerfile](https://github.com/INCATools/ontology-development-kit/blob/master/Dockerfile) updated and an [ODK issue](https://github.com/INCATools/ontology-development-kit/issues/new) submitted | ||
- [ ] No | ||
|
||
### PR Review and Conversations Resolved | ||
- Has the PR been sufficiently reviewed by at least one team member of the Mondo Technical team and all threads resolved? | ||
- [ ] Yes |