[Feature]: Implement FaceID to unlock the app on open #1020
Conversation
There was a problem hiding this comment.
You completely destroyed the old app delegate by overwriting it with a new one essentially doing nothing.
Face-Id to unlock the app should do exactly that: block the app UI until unlocked by face-id. It should not block all functions of the app indefinitely, nor should it block the app connecting in the background and fetching messages etc. while waiting for the faceid unlock.
We are transitioning away from UIKit and storyboards and all new UI should use SwiftUI --> please use SwiftUI for the UI
Your PR doesn't compile and throws a storyboard compilation error.
Please don't create an extra Controller directory but add all your code files to the Classes directory.
Please add all new files to the XCode project as well and make sure to add them to the correct target (Monal, not monalxmpp or NotificationServiceExtension etc.)
| } | ||
| func showBiometricsSettingsAlert(_ controller: UIViewController) { | ||
| let alertController = UIAlertController( | ||
| title: "Enable Face ID/Touch ID", |
There was a problem hiding this comment.
please mark these as translatable
There was a problem hiding this comment.
all user-facing text should be made translatable, I skip adding this comment to every of these texts to not clutter the review
|
|
||
| private init() {} | ||
|
|
||
| func storeLoginInfo(email: String, password: String) { |
There was a problem hiding this comment.
we don't have emails in xmpp, I guess you meant jid?
tmolitor-stud-tu
force-pushed
the
develop
branch
from
6d3c4e4
to
9db05d1
Compare
|
We are using a rebase based workflow rather than a merge based and sometimes force-push something into one of the top commits. Please rebase this PR upon current develop and remove all commits not being yours by calling: |
tmolitor-stud-tu
force-pushed
the
develop
branch
2 times, most recently
from
951f346
to
f53ec86
Compare
tmolitor-stud-tu
force-pushed
the
develop
branch
from
3f9ec84
to
bcd67e8
Compare
Issue #992
Tried to implement FaceID unlock to app Open