Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't plugging third-party Promise library for ioredis in RedisTransporter #1290

Conversation

kuzalekon
Copy link

📝 Description

ioredis v5 does not support plugging third-party Promise library anymore.
Now, when Redis transporter starts, the corresponding message is displayed in the console: "ioredis v5 does not support plugging third-party Promise library anymore. Native Promise will be used". See this block of code in ioredis package.

💎 Type of change

  • ✅ Bug fix (non-breaking change which fixes an issue)

🏁 Checklist:

  • ✅ My code follows the style guidelines of this project
  • ✅ I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • ✅ I have commented my code, particularly in hard-to-understand areas

ioredis v5 does not support plugging third-party Promise library anymore.
@faller
Copy link

faller commented Jul 25, 2024

How's it going now?

@icebob icebob merged commit 1b0dff5 into moleculerjs:master Jul 28, 2024
177 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants