-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): add middlewares types #1161
base: master
Are you sure you want to change the base?
feat(types): add middlewares types #1161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things here:
- What's the use case for making this change?
- Although there are many places in the existing types where
namespace
is used, its a pattern I'd prefer to avoid in the future. Can the changes you're making be accomplished without using them? - Types should always be PascalCase and not camelCase. There are several changes here using camelCase.
- remove namespaces - rename types as PascalCase
- fix TU
@shawnmcknight any news on this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good. I had a few requests for adjustment.
- back to namespaces - correct PascalCase
Please @shawnmcknight / @icebob can you review this PR ? it is waiting for nearly a year, where PR #1246 with same changes was validated in 2 days (litterally the PR just re-do a part of this one) ... |
Add typing for the optionals middlewares
PS : I typed the encryption middleware too, but I think it's not a good middleware, not secure (IV not changing), and hard to use (password length need to be a strict length)
💎 Type of change
🏁 Checklist: