eslint9 migration

benchmark/memleak-test.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 "use strict";
 
 const kleur = require("kleur");

benchmark/perf-runner.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console, no-unused-vars */
-
 "use strict";
 
 const fs = require("fs");

benchmark/suites/serializers.js

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 "use strict";
 
 const ServiceBroker = require("../../src/service-broker");

benchmark/suites/throughput.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 "use strict";
 
 const kleur = require("kleur");

eslint.config.js

@@ -0,0 +1,70 @@
+const js = require("@eslint/js");
+const globals = require("globals");
+const pluginSecurity = require('eslint-plugin-security');
+
+/** @type {import('eslint').Linter.FlatConfig[]} */
+module.exports = [
+	js.configs.recommended,
+	pluginSecurity.configs.recommended,
+	//"plugin:security/recommended-legacy",
+	//"plugin:prettier/recommended",
+	{
+		files: ["**/*.js", "**/*.mjs"],
+		languageOptions: {
+			parserOptions: {
+				sourceType: "module",
+				ecmaVersion: 2023
+			},
+			globals: {
+				...globals.node,
+				...globals.es2020,
+				...globals.commonjs,
+				...globals.es6,
+				...globals.jquery,
+				...globals.jest,
+				...globals.jasmine,
+				process: "readonly",
+				fetch: "readonly"
+			}
+		},
+		// plugins: ["node", "security"],
+		rules: {
+			"no-var": ["error"],
+			"no-console": ["error"],
+			"no-unused-vars": ["warn"],
+			"no-trailing-spaces": ["error"],
+			"security/detect-object-injection": ["off"],
+			"security/detect-non-literal-require": ["off"],
+			"security/detect-non-literal-fs-filename": ["off"],
+			"no-process-exit": ["off"],
+			"node/no-unpublished-require": 0
+		},
+		ignores: ["benchmark/test.js", "test/typescript/hello-world/out/*.js"],
+	}, {
+		files: ["test/typescript/hello-world/out/*.js"],
+		languageOptions: {
+			globals: {
+				exports: "readonly",
+				require: "readonly",
+				__dirname: "readonly",
+				console: "readonly",
+				process: "readonly",
+			}
+		},
+		rules: {
+			"no-unused-vars": ["off"]
+		}
+	}, {
+		files: ["test/**/*.js"],
+		rules: {
+			"no-console": ["off"],
+			"no-unused-vars": ["off"]
+		}
+	}, {
+		files: ["dev/**/*.js", "benchmark/**/*.js", "examples/**/*.js"],
+		rules: {
+			"no-console": ["off"],
+			"no-unused-vars": ["off"]
+		}
+	}
+];

examples/client-server/client.js

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 "use strict";
 
 let _ = require("lodash");

examples/loadtest/client.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 "use strict";
 
 let { times, random, padStart } = require("lodash");

examples/loadtest/clients.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 "use strict";
 
 const os = require("os"),

examples/loadtest/local.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 "use strict";
 
 let random = require("lodash/random");

examples/loadtest/nats.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 let nc1 = require("nats").connect();
 let nc2 = require("nats").connect();
 

examples/loadtest/server.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 "use strict";
 
 let ServiceBroker = require("../../src/service-broker");

examples/middlewares/index.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 "use strict";
 
 let path = require("path");

examples/multi-nodes/master.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 "use strict";
 
 const path = require("path");

examples/multi-nodes/node-controller.service.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 const _ = require("lodash");
 const kleur = require("kleur");
 const cluster = require("cluster");

examples/multi-nodes/node.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 "use strict";
 
 const _ = require("lodash");

examples/opentelemetry/index.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 "use strict";
 
 // Instead use `-r ./tracing.js` // require("./tracing");

package.json

@@ -19,8 +19,8 @@
     "deps": "ncu -i --format group",
     "postdeps": "npm run lint:lock && npm test",
     "dev": "nodemon dev/index.js",
-    "lint": "eslint --ext=.js benchmark bin examples src test",
-    "lint:fix": "eslint --fix --ext=.js benchmark bin examples src test",
+    "lint": "eslint benchmark bin examples src test",
+    "lint:fix": "eslint --fix benchmark bin examples src test",
     "lint:lock": "lockfile-lint --path package-lock.json --type npm --validate-https --allowed-hosts npm",
     "perf": "nodemon --allow-natives-syntax benchmark/perf-runner.js",
     "pperf": "node --inspect --expose-gc benchmark/perf-runner.js",

src/loggers/formatted.js

@@ -4,8 +4,6 @@
  * MIT Licensed
  */
 
-/* eslint-disable no-console */
-
 "use strict";
 
 const BaseLogger = require("./base");

src/runner-esm.mjs

@@ -118,7 +118,7 @@ export default class MoleculerRunner {
 
 				if (this.flags.envfile) dotenv.config({ path: this.flags.envfile });
 				else dotenv.config();
-			} catch (err) {
+			} catch {
 				throw new Error(
 					"The 'dotenv' package is missing! Please install it with 'npm install dotenv --save' command."
 				);
@@ -216,7 +216,7 @@ export default class MoleculerRunner {
 
 		try {
 			return require.resolve(configPath, resolveOptions);
-		} catch (_) {
+		} catch {
 			return null;
 		}
 	}
@@ -320,7 +320,7 @@ export default class MoleculerRunner {
 	isDirectory(p) {
 		try {
 			return fs.lstatSync(p).isDirectory();
-		} catch (_) {
+		} catch {
 			// ignore
 		}
 		return false;
@@ -335,7 +335,7 @@ export default class MoleculerRunner {
 	isServiceFile(p) {
 		try {
 			return !fs.lstatSync(p).isDirectory();
-		} catch (_) {
+		} catch {
 			// ignore
 		}
 		return false;

src/runner.js

@@ -128,7 +128,7 @@ class MoleculerRunner {
 
 				if (this.flags.envfile) dotenv.config({ path: this.flags.envfile });
 				else dotenv.config();
-			} catch (err) {
+			} catch {
 				throw new Error(
 					"The 'dotenv' package is missing! Please install it with 'npm install dotenv --save' command."
 				);
@@ -227,7 +227,7 @@ class MoleculerRunner {
 
 		try {
 			return require.resolve(configPath, resolveOptions);
-		} catch (_) {
+		} catch {
 			return null;
 		}
 	}
@@ -331,7 +331,7 @@ class MoleculerRunner {
 	isDirectory(p) {
 		try {
 			return fs.lstatSync(p).isDirectory();
-		} catch (_) {
+		} catch {
 			// ignore
 		}
 		return false;
@@ -346,7 +346,7 @@ class MoleculerRunner {
 	isServiceFile(p) {
 		try {
 			return !fs.lstatSync(p).isDirectory();
-		} catch (_) {
+		} catch {
 			// ignore
 		}
 		return false;