Bridge /rosout #21
Merged
Bridge /rosout #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens for rcl_interfaces/Log 'header.stamp' gets mapped to 'stamp'. For the old check on both messages where some fields missing: 'topics' in ros2 and 'stamp' in ros1. That 'stamp' was mapped via the custom rule above wasn't recognized by the old logic. For now we say if there a custom field mappings for a field we skip this check.
Deleh
force-pushed
the
feature/bridge-log
branch
from
4282c29
to
3f86127
Compare
Deleh
previously approved these changes
Oct 30, 2024
hoffmann-stefan
force-pushed
the
feature/bridge-log
branch
from
2620ca3
to
e1c358c
Compare
Deleh
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref ros2#391
This fixes the conversion between
rosgraph_msgs/Logandrcl_interfaces/Log.What is missing is a custom converter for the
levelconstant values, as they differ between ROS1 and ROS2...This already works for foxglove/lichtblick as it seems to accept both set of constants.
But rqt crashes when it sees an unknown (to ROS1) level constatnt.
So we need to extend this with a custom converter for this message pair.->Done