Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types in configs for v2.8 #912

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Fix types in configs for v2.8 #912

merged 4 commits into from
Sep 22, 2023

Conversation

Tetrergeru
Copy link
Member

No description provided.

@Tetrergeru Tetrergeru changed the title Fix types in configs Fix types in configs for v2.8 Sep 12, 2023
@Tetrergeru
Copy link
Member Author

/build

@Tetrergeru
Copy link
Member Author

/build

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #912 (6a2811b) into v2.8 (4e9751c) will increase coverage by 0.02%.
The diff coverage is 90.90%.

❗ Current head 6a2811b differs from pull request most recent head c8bcf53. Consider uploading reports for the commit c8bcf53 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             v2.8     #912      +/-   ##
==========================================
+ Coverage   69.60%   69.62%   +0.02%     
==========================================
  Files         191      191              
  Lines       10596    10585      -11     
==========================================
- Hits         7375     7370       -5     
+ Misses       2792     2787       -5     
+ Partials      429      428       -1     
Files Changed Coverage Δ
cmd/cli/from_2.7_to_2.8.go 0.00% <0.00%> (ø)
cmd/cli/main.go 0.00% <ø> (ø)
senders/webhook/webhook.go 54.34% <60.00%> (+1.15%) ⬆️
cmd/cli/cluster.go 63.93% <88.88%> (+2.39%) ⬆️
senders/discord/init.go 45.65% <100.00%> (-1.16%) ⬇️
senders/mail/mail.go 47.45% <100.00%> (ø)
senders/mattermost/sender.go 86.36% <100.00%> (+1.06%) ⬆️
senders/msteams/msteams.go 80.00% <100.00%> (-0.46%) ⬇️
senders/opsgenie/init.go 78.94% <100.00%> (ø)
senders/pagerduty/init.go 81.81% <100.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Tetrergeru
Copy link
Member Author

/build

@github-actions
Copy link

Build and push Docker images with tag: fix-proper-types-in-configs.2023-09-21.c8bcf53

@Tetrergeru Tetrergeru marked this pull request as ready for review September 22, 2023 10:17
@Tetrergeru Tetrergeru requested a review from a team as a code owner September 22, 2023 10:17
@Tetrergeru Tetrergeru merged commit 2f5f4b3 into v2.8 Sep 22, 2023
4 checks passed
@Tetrergeru Tetrergeru deleted the fix/proper-types-in-configs branch September 22, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants