Refactor Senders initialization #804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimedrolity
force-pushed
the
feature/sender-constructor
branch
from
e1153b4
to
d95eeb1
Compare
Dimedrolity
changed the title
Codecov Report
@@ Coverage Diff @@
## master #804 +/- ##
==========================================
- Coverage 71.32% 71.30% -0.02%
==========================================
Files 179 179
Lines 9322 9348 +26
==========================================
+ Hits 6649 6666 +17
- Misses 2293 2303 +10
+ Partials 380 379 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Dimedrolity
force-pushed
the
feature/sender-constructor
branch
3 times, most recently
from
b56416b
to
82fdc94
Compare
|
Want to move senders directory to notifier directory, because senders have no sense without notifier. Also errors.go in the root of Moira contains Notifier erros, should be also moved to notifier dir. |
Dimedrolity
force-pushed
the
feature/sender-constructor
branch
from
b62ddd7
to
1fa56b2
Compare
|
kissken
requested changes
Nov 28, 2022
notifier/senders/msteams/msteams.go
Outdated
| sender.logger = logger | ||
| sender.location = location | ||
| sender.frontURI = senderSettings["front_uri"] | ||
| maxEvents, err := strconv.Atoi(senderSettings["max_events"]) | ||
| if err != nil { | ||
| return fmt.Errorf("max_events should be an integer: %w", err) | ||
| return nil, fmt.Errorf("max_events should be an integer: %w", err) | ||
| } | ||
| sender.maxEvents = maxEvents | ||
| sender.client = &http.Client{ | ||
| Timeout: time.Duration(30) * time.Second, //nolint |
There was a problem hiding this comment.
Ok, done db17931
There was a problem hiding this comment.
I just drop //nolint, it is not necessary to refactor all Moira code. This const timeout is so little thing compare to problems that we have in Moira, so I advise you don't pay attention to it.
Tetrergeru
reviewed
Nov 28, 2022
Tetrergeru
requested changes
Nov 28, 2022
Dimedrolity
force-pushed
the
feature/sender-constructor
branch
from
ff6e0a5
to
78f40bf
Compare
Tetrergeru
previously approved these changes
Dec 5, 2022
Use constructor function NewSender instead of Init method, remove Init method from Sender interface.
Rename `init.go` files to `sender.go`, because files no more contain Init method.
Moved senders directory to notifier directory, because senders have no sense without notifier, senders is a part of notifier. Also resolve some warnings
Dimedrolity
force-pushed
the
feature/sender-constructor
branch
from
78f40bf
to
8ad4ba1
Compare
kissken
reviewed
Dec 7, 2022
kissken
reviewed
Dec 7, 2022
|
merge after release |
|
and let's make pretty commit messages |
|
We don't need |
Tetrergeru
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #797