feat(notifier): add selfstate monitor #1118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almostinf
changed the base branch from
master
to
feat/add-selfstate-heartbeats
cmd/notifier/main.go
Outdated
|
|
||
| // Start moira selfstate checker | ||
| if selfstateCfg.Enabled { | ||
| fmt.Println(selfstateCfg) |
There was a problem hiding this comment.
Suggested change
| fmt.Println(selfstateCfg) |
AleksandrMatsko
approved these changes
Nov 6, 2024
Tetrergeru
reviewed
Nov 8, 2024
| LastCheckDelay: "60s", | ||
| NoticeInterval: "300s", | ||
| Selfstate: selfstateConfig{ | ||
| Enabled: false, |
There was a problem hiding this comment.
А нужно ли заполнять остальной конфиг, если он по умолчанию выключен? Или типа на случай, если включал и чего-то не заполнят?
There was a problem hiding this comment.
Просто оставил старые значения, могу убрать
Tetrergeru
reviewed
Nov 8, 2024
| type AdminMonitorConfig struct { | ||
| MonitorBaseConfig | ||
|
|
||
| AdminContacts []map[string]string `validate:"required_if=Enabled true"` |
There was a problem hiding this comment.
А почему map[string]string, структуру нельзя сделать?
There was a problem hiding this comment.
Перенес старый вариант, менять на структуру сейчас?
Tetrergeru
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add selfstate monitor