feat(notifier): refactor selfstate heartbeaters #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrMatsko
approved these changes
Nov 6, 2024
Tetrergeru
reviewed
Nov 6, 2024
| func (check *localChecker) Check(nowTS int64) (int64, bool, error) { | ||
| defaultLocalCluster := moira.DefaultLocalCluster | ||
| triggersCount, err := check.database.GetTriggersToCheckCount(defaultLocalCluster) | ||
| // Check is a function that checks that the local checker checks triggers and the number of triggers is not constant. |
There was a problem hiding this comment.
А я правильно понимаю, что если случайно количество чекав будет одинаковое две проверки подряд, то будет переход в ERROR?
There was a problem hiding this comment.
Это не количество чеков, это счетчик, который увеличивается с каждой проверкой триггера, если за 2 проверки монитора счетчик не изменился, то local checker не работает, логика такая
There was a problem hiding this comment.
Эту логику я не менял, просто подрефакторил
Tetrergeru
approved these changes
Nov 6, 2024
almostinf
changed the base branch from
feat/add-emergency-contacts-api
to
feat/add-emergency-contacts-allowed-list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor selfstate heartbeaters