fix: trigger schedule fill #1116

AleksandrMatsko · 2024-10-29T11:50:36Z

PR Summary

Before this PR Trigger with not all days in the schedule could be created.

Now the following rules will be applied:

if some days are missed they will be marked Enabled = false;
if day name not in [Mon, Tue, Wed, Thu, Fri, Sat, Sun] the error will be returned;
if days are unordered they will be ordered from Mon to Sun;
if there is no days with Enabled = true the error will be returned;

api/dto/triggers.go

AleksandrMatsko · 2024-11-06T04:35:57Z

/build

github-actions · 2024-11-06T13:48:37Z

Build and push Docker images with tag: 2024-11-06.a16c390

fix: schedule validation

f260674

AleksandrMatsko requested a review from a team as a code owner October 29, 2024 11:50

fix: failed test

fa8516a

AleksandrMatsko changed the title ~~fix: trigger schedule validation~~ fix: trigger schedule fill Oct 29, 2024

AleksandrMatsko added 2 commits October 29, 2024 19:26

feat: check for at least one day enabled

27c98f1

merge master into fix/trigger-schedule-fill

39636a4

mchrome reviewed Oct 30, 2024

View reviewed changes

api/dto/triggers.go Outdated Show resolved Hide resolved

AleksandrMatsko added 3 commits November 1, 2024 09:54

merge master into fix/trigger-schedule-fill

07de888

refactor: merge schedule logic add some tests

7bb137d

test: in package handler

ebe85ea

Tetrergeru approved these changes Nov 1, 2024

View reviewed changes

mchrome approved these changes Nov 1, 2024

View reviewed changes

almostinf approved these changes Nov 5, 2024

View reviewed changes

merge master into fix/trigger-schedule-fill

c4fa1d1

AleksandrMatsko merged commit a16c390 into master Nov 6, 2024
7 checks passed

AleksandrMatsko deleted the fix/trigger-schedule-fill branch November 6, 2024 13:46