feat(build): drop root privileges, update .dockerignore #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename the user from 'app' to 'modmail', and made it a system user instead. - Moved user creation to a higher layer in the Dockerfile. Signed-off-by: Taku <[email protected]>
Removed LICENSE, PRIVACY.md, and SPONSORS.json from .dockerignore. Although they don't affect the functionalities of the bot, we prefer to include them due to their respective purposes. Signed-off-by: Taku <[email protected]>
Taaku18
approved these changes
Jul 9, 2023
There was a problem hiding this comment.
Hello @suprovsky, thanks for the PR.
I removed a few of the .dockerignore additions, since they should be included in the image. I also added the .git directory as suggested.
I also slightly modified the Dockerfile by renaming the user to 'modmail' and moving to a higher layer.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will prevent from using root user in order to run the application. I also updated
.dockerignoreso you have less files in the image. I wasn't sure if you need.gitfor some reason in the image so I left it inside. But if you don't need it then it should be included in.dockerignoreas well.