Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#425: Fix type of shared MPI.buffer #426

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Retribution98
Copy link
Collaborator

Mpi4py changed the default MPI.buffer type from signed char ('b') to unsigned char ('B'), which is the cause of incorrect data deserialization.

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 .
  • passes black .
  • signed commit with git commit -s
  • Resolves [MPI] Fix hangs and errors when reading from shared memory #425
  • tests added and passing
  • module layout described at docs/developer/architecture.rst is up-to-date

@Retribution98 Retribution98 self-assigned this Sep 12, 2024
@YarShev YarShev merged commit 1599cca into modin-project:master Sep 13, 2024
25 checks passed
YarShev pushed a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MPI] Fix hangs and errors when reading from shared memory
2 participants