Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF-#5613: Optimize duplicated in case there is only one column partition #5640

Merged
merged 5 commits into from
Mar 3, 2023
Merged

PERF-#5613: Optimize duplicated in case there is only one column partition #5640

merged 5 commits into from
Mar 3, 2023

Conversation

YarShev
Copy link
Collaborator

@YarShev YarShev commented Feb 8, 2023

Signed-off-by: Igoshev, Iaroslav [email protected]

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Optimize duplicated in case there is only one column partition #5613
  • tests passing
  • module layout described at docs/development/architecture.rst is up-to-date

@YarShev YarShev marked this pull request as ready for review February 8, 2023 21:53
@YarShev YarShev requested a review from a team as a code owner February 8, 2023 21:53
@YarShev
PERF-modin-project#5613: Optimize duplicated in case there is only …
2c150ad 
…one column partition

Signed-off-by: Igoshev, Iaroslav <[email protected]>
@YarShev
Remove new params
cda0b9c 
Signed-off-by: Igoshev, Iaroslav <[email protected]>
dchigarev
dchigarev reviewed Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, left a couple of comments

modin/core/storage_formats/pandas/query_compiler.py Outdated Show resolved Hide resolved
modin/core/dataframe/pandas/dataframe/dataframe.py Outdated Show resolved Hide resolved
modin/core/storage_formats/pandas/query_compiler.py Show resolved Hide resolved
@YarShev
Address comment
f508fef 
Signed-off-by: Igoshev, Iaroslav <[email protected]>
dchigarev
dchigarev approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@anmyachev anmyachev merged commit 5010a6d into modin-project:master Mar 3, 2023
@anmyachev anmyachev mentioned this pull request Oct 14, 2023
Closed
@YarShev YarShev deleted the dev/yigoshev-issue5613 branch November 2, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

@anmyachev anmyachev anmyachev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize duplicated in case there is only one column partition
3 participants
@YarShev @anmyachev @dchigarev