Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Add WebRender #807

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

[PoC] Add WebRender #807

wants to merge 16 commits into from

Conversation

nullptr-w8
Copy link
Contributor

Webrender

fix

fir
@kamronbatman
Copy link
Contributor

This is great!
I think this will become impractical without performance issues. Eventually we will want to provide html from CDN.
Maybe we can simply provide a URL?

@nullptr-w8
Copy link
Contributor Author

nullptr-w8 commented Sep 27, 2021

This is great!
I think this will become impractical without performance issues. Eventually we will want to provide html from CDN.
Maybe we can simply provide a URL?

Yeah, we can use URL, but for now only content we use original socket or store page in client for admin client. At the moment, I try to swap sciter in client(only basic JS like jquery t's use for example gump) to sctier.JS(cdn + vue,react,etc)

@kamronbatman
Copy link
Contributor

@nullptr-w8 Let's move forward with this in some fashion:
@michaelwhelehan and @jabinb, I would love to know your thoughts. I see this working out by doing the following:

  1. Build gumps using HTML/CSS/JS.
  2. Generate the final bundle of files.
  3. Host them archived, or individually on CDN.
  4. In-game gumps will be a URL to that bundle, which would then be cached and versioned.
  5. Gumps send additional dynamic data (strings and potentially the rest) via the rest of the gump packet.

# Conflicts:
#	Projects/Benchmarks/Benchmarks/Packets/GumpUtilities.cs
#	Projects/Server/Gumps/Gump.cs
#	Projects/Server/Network/Packets/IncomingPlayerPackets.cs
#	Projects/Server/Network/Packets/OutgoingGumpPackets.cs
@paezao
Copy link
Member

paezao commented May 28, 2024

@kamronbatman should we close this at this point?

@kamronbatman
Copy link
Contributor

I was keeping this open as a PoC. Let's put it into draft.

@kamronbatman kamronbatman marked this pull request as draft May 29, 2024 05:32
@kamronbatman kamronbatman changed the title Add WebRender [PoC] Add WebRender May 29, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kamronbatman
❌ nullptr-w8
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants