fix: Fixes Timer crash due to negative inputs.

[kamronbatman]

Summary

Fixes a few minor issues with timers:

• Timer.Delay and Timer.Interval was not reflecting the actual tick time (aligned to the next 8ms)
• Negative delay values were causing a crash when DateTime.Now - delay was below DateTime.MinValue
• Timer.Next now reflects the correct wall clock tick time based on the adjusted Delay.
• Timer.Next is not assigned when the timer is started. This was important for timers that were created, but started later.

[kamronbatman]

Note that Next is now assigned when the timer is added. It no longer erroneously reflects the Next tick based on when the timer is added.

[github-actions]

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 20 dependencies

Third-party software list

This page lists the third-party software dependencies used in ModernUO

Dependency	Version	Licenses
Argon2.Bindings	1.16.1	MIT
BouncyCastle.Cryptography	2.4.0	MIT
CommunityToolkit.HighPerformance	8.3.2	MIT
LibDeflate.Bindings	1.0.2.120	GPL-3.0-only
MailKit	4.8.0	MIT
Microsoft.Extensions.FileSystemGlobbing	8.0.0	MIT
MimeKit	4.8.0	MIT
ModernUO.CodeGeneratedEvents.Annotations	1.0.0	GPL-3.0-only
ModernUO.CodeGeneratedEvents.Generator	1.0.3.2	GPL-3.0-only
ModernUO.Serialization.Annotations	2.9.1	GPL-3.0-only
ModernUO.Serialization.Generator	2.11.3	GPL-3.0-only
Nerdbank.GitVersioning	3.6.143	MIT
PollGroup	1.5.1	BSD-3-Clause
Serilog.Sinks.Async	2.0.0	Apache-2.0
Serilog.Sinks.Console	6.0.0	Apache-2.0
Serilog	4.0.2	Apache-2.0
System.Formats.Asn1	8.0.1	MIT
System.IO.Hashing	8.0.0	MIT
System.Security.Cryptography.Pkcs	8.0.0	MIT
Zstd.Binaries	1.6.0	MIT

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions