Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor/restyle HouseGump and supporting gumps #1925

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

IcculusC
Copy link
Contributor

@IcculusC IcculusC commented Aug 12, 2024

In this PR I've consolidated the HouseListGump and HouseRemoveGump into a newly-refactored, multi-page HouseGump.

Additionally, I added some imagery and rearranged some of the options.

I did this mostly as an exercise in creating complex gumps, but it's also a bit of an upgrade. The real question is whether or not the "paged" gump is a good thing. I've effectively built this such that it wouldn't be prohibitively difficult to break each page into it's own gump. I have since refactored to use a "sectional" gump. Each section (Info, Friends, and Options) is rendered as the first page in the gump, and the paging behavior for house sign selection and people management are encompassed by section. This means the entire gump is no longer one giant paged gump, and prevents building the layout for the people lists when a user is only viewing the info section (for example).

Sections

  • Info
  • Friends
    • Co-Owners Page
    • Friends Page
    • Bans Page
  • Options
    • Sign Selection Page(s)

There are many pages and variations, so I have only included the significant stylistic changes here.

homepage
image

private house options
image

public house options
image

sign selection
image

Copy link

github-actions bot commented Aug 12, 2024

Qodana for .NET

3 new problems were found

Inspection name Severity Problems
Private field can be converted into local variable 🔶 Warning 2
Namespace does not correspond to file location ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 18 dependencies

Third-party software list

This page lists the third-party software dependencies used in ModernUO

Dependency Version Licenses
Argon2.Bindings 1.16.1 MIT
BouncyCastle.Cryptography 2.4.0 MIT
CommunityToolkit.HighPerformance 8.2.2 MIT
LibDeflate.Bindings 1.0.2.120 GPL-3.0-only
MailKit 4.7.1.1 MIT
Microsoft.Extensions.FileSystemGlobbing 8.0.0 MIT
MimeKit 4.7.1 MIT
ModernUO.Serialization.Annotations 2.9.1 GPL-3.0-only
ModernUO.Serialization.Generator 2.11.3 GPL-3.0-only
Nerdbank.GitVersioning 3.6.139 MIT
PollGroup 1.5.1 BSD-3-Clause
Serilog.Sinks.Async 2.0.0 Apache-2.0
Serilog.Sinks.Console 6.0.0 Apache-2.0
Serilog 4.0.1 Apache-2.0
System.Formats.Asn1 8.0.1 MIT
System.IO.Hashing 8.0.0 MIT
System.Security.Cryptography.Pkcs 8.0.0 MIT
Zstd.Binaries 1.6.0 MIT
Contact Qodana team

Contact us at [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant