Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restyle and simplify implementation of ResurrectGump #1923

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

IcculusC
Copy link
Contributor

@IcculusC IcculusC commented Aug 11, 2024

This includes a simple overhaul of the OSI style default ResurrectGump to have a little bit of personality. Unfortunately there are limitations with the associated cliloc message. It includes the CONTINUE and CANCEL text, and uses additional cliloc messages to label the buttons. See here for hints on what cliloc messages need to be updated if you wish to modify the gump copy.

Additionally I refactored the gump to simplify the implementation and reuse the background/images in both styles.

ResurrectGump
image

ResurrectGump with a price
image

Copy link

github-actions bot commented Aug 11, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 18 dependencies

Third-party software list

This page lists the third-party software dependencies used in ModernUO

Dependency Version Licenses
Argon2.Bindings 1.16.1 MIT
BouncyCastle.Cryptography 2.4.0 MIT
CommunityToolkit.HighPerformance 8.2.2 MIT
LibDeflate.Bindings 1.0.2.120 GPL-3.0-only
MailKit 4.7.1.1 MIT
Microsoft.Extensions.FileSystemGlobbing 8.0.0 MIT
MimeKit 4.7.1 MIT
ModernUO.Serialization.Annotations 2.9.1 GPL-3.0-only
ModernUO.Serialization.Generator 2.11.3 GPL-3.0-only
Nerdbank.GitVersioning 3.6.139 MIT
PollGroup 1.5.1 BSD-3-Clause
Serilog.Sinks.Async 2.0.0 Apache-2.0
Serilog.Sinks.Console 6.0.0 Apache-2.0
Serilog 4.0.1 Apache-2.0
System.Formats.Asn1 8.0.1 MIT
System.IO.Hashing 8.0.0 MIT
System.Security.Cryptography.Pkcs 8.0.0 MIT
Zstd.Binaries 1.6.0 MIT
Contact Qodana team

Contact us at [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants